RussellSpitzer commented on code in PR #16285:
URL: https://github.com/apache/iceberg/pull/16285#discussion_r4329259498
##########
core/src/test/java/org/apache/iceberg/TestV4ManifestReader.java:
##########
@@ -172,7 +172,8 @@ public void readDataFile(FileFormat format) throws
IOException {
DV,
null, // manifest info
ByteBuffer.wrap(new byte[] {1, 2, 3}), // key metadata
- ImmutableList.of(50L, 100L));
+ ImmutableList.of(50L, 100L),
+ null); // column files
Review Comment:
I agree with doing the V4ManifestReader change now. All these nulls seem
unnecessary and I think the fix for this is pretty small. I think the net prod
changes is just
```java
// TrackedFile.java
int COLUMN_FILES_ELEMENT_ID = 159;
Types.NestedField COLUMN_FILES =
Types.NestedField.optional(
158,
"column_files",
Types.ListType.ofRequired(COLUMN_FILES_ELEMENT_ID,
ColumnFile.schema()),
"Column files");
// V4ManifestReader.open()
.setCustomType(TrackedFile.COLUMN_FILES_ELEMENT_ID, ColumnFileStruct.class)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
