kevinjqliu opened a new pull request, #3495:
URL: https://github.com/apache/iceberg-rust/pull/3495

   ## Which issue does this PR close?
   
   - Related to 
[#3239](https://redirect.github.com/apache/iceberg-rust/issues/3239) and the 
wheel license work in 
[#3493](https://redirect.github.com/apache/iceberg-rust/issues/3493).
   
   ## What changes are included in this PR?
   
   Parquet's default `brotli` feature and zstd's `legacy` feature aren't used 
by us, but they pull in extra third-party code (`brotli-decompressor`'s MIT 
half, legacy zstd BSD-2 decoders) that then needs attribution in the 
`pyiceberg-core` wheel LICENSE. Turning off default features on both (and 
keeping the parquet features we actually use) avoids that.
   
   **Caveat:** Brotli-compressed Parquet files can no longer be read.
   
   ## Are these changes tested?
   
   Dependency-only change, covered by existing tests:
   - `cargo check --all-targets`: passed
   - `cargo test -p iceberg --lib`: passed (1991 passed, 0 failed)
   
   ## AI Disclosure
   
   <!--
   
https://iceberg.apache.org/contribute/#guidelines-for-ai-assisted-contributions
   -->
   
   Drafted with Copilot. Worth a look: whether dropping Brotli read support is 
acceptable, and that no other crate relies on parquet's default features.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to