rdblue commented on issue #1617: URL: https://github.com/apache/iceberg/issues/1617#issuecomment-765667338
Hi Anurag, I read the doc through the Proposal and Approach sections and I am quite confused about what your proposal is. Could you clarify it a bit? It may be obvious from the following example sections what the changes are and why they are needed, but I think that information should be in the proposal/approach. rb On Fri, Jan 22, 2021 at 11:31 AM Anurag Mantripragada < [email protected]> wrote: > Thanks for your comments @jackye1995 <https://github.com/jackye1995>. We > discussed your proposal and here are our thoughts. > > - Making no changes to the file paths and relying on FileIO > implementations to internally interpret them differently can cause > confusion since the same path could mean totally different locations based > on the underlying implementation. > > With our approach, > > - The path we see in metadata files is the path that gets acted upon. > We feel this is cleaner and causes less confusion. > - Further, when we use relative paths, they will always be relative to > the table. This invariant makes it easier to interpret the paths. > > For the reasons above, we prefer the approach laid out in the design doc. > We understand the concerns around Iceberg spec with v2 format already > changing a lot. We are open to ideas on shipping this with the least > interference (even if it means we wait till v2 gets out). > > Please let us know your thoughts. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/iceberg/issues/1617#issuecomment-765637049>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAAVO2YIGCLMOI5X7UQ7E2TS3HHBTANCNFSM4SSQSL7A> > . > -- Ryan Blue ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
