Revanth14 opened a new pull request, #2245: URL: https://github.com/apache/iceberg-go/pull/2245
## Problem Follow-up to #2189. The reserved position delete field IDs were defined separately in four places: the literals in `PositionalDeleteSchema`, private constants in `table/data_file_meta.go` and `table/internal/parquet_files.go`, and `math.MaxInt32 - 101/102` in `table/inspect_position_deletes.go`. Nothing kept them in sync. ## Fix Add `iceberg.DeleteFilePathFieldID` (2147483546) and `iceberg.DeleteFilePosFieldID` (2147483545) to `metadata_columns.go`, next to the row lineage IDs. The names follow Java's `MetadataColumns.DELETE_FILE_PATH` and `DELETE_FILE_POS`. `PositionalDeleteSchema` and the three table call sites now use them, and the private copies are removed. Test files keep their literals. ## Testing No behavior change: the values are identical. gofmt, `go vet ./...` and `go test -race ./...` pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
