dhruvarya-db commented on code in PR #3431:
URL: https://github.com/apache/iceberg-rust/pull/3431#discussion_r4331555062
##########
crates/iceberg/src/spec/partition.rs:
##########
@@ -630,9 +632,13 @@ impl PartitionSpecBuilder {
///
/// If partition field id is set, it is used as the field id.
/// Otherwise, a new `field_id` is assigned.
- pub fn add_unbound_field(mut self, field: UnboundPartitionField) ->
Result<Self> {
- self.check_name_set_and_unique(&field.name)?;
+ pub fn add_unbound_field(self, field: UnboundPartitionField) ->
Result<Self> {
self.check_for_redundant_partitions(&field.source_ids,
&field.transform)?;
Review Comment:
Updated + test_add_unbound_field_checks_name_before_redundancy tests for the
error message
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
