Revanth14 opened a new pull request, #145:
URL: https://github.com/apache/terraform-provider-iceberg/pull/145
## Problem
Reading a partition spec kept only the first source ID of each field, so a
v3 multi-source field with `source-ids: [1, 2]` came back as `[1]` in resource
and data-source state. Part of #112 ("Support multi-source partition fields").
## Fix
`icebergTablePartitionSpec.FromIceberg` now copies every entry of
`PartitionField.SourceIDs` instead of calling `SourceID()`. The write path
already sends `source-ids` through JSON, and the `source_ids` attribute is
already a list, so there is no schema or state change.
## Testing
`TestPartitionSpecSourceIDsRoundTrip` converts single- and multi-source
specs from iceberg-go to the provider model and back, and checks both the
source IDs and spec equality. It fails without the fix. `go test -race ./...`,
`make test-integration`, golangci-lint and staticcheck pass.
## Context
Multi-source sort fields are a separate item on #112: `source_id` is a
scalar there, so that change needs a schema change and a state upgrader.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
