anoopj commented on code in PR #3483:
URL: https://github.com/apache/iceberg-rust/pull/3483#discussion_r4333159890
##########
crates/iceberg/src/scan/mod.rs:
##########
@@ -1195,6 +1195,55 @@ mod tests {
);
}
+ #[tokio::test]
+ async fn test_scan_widens_old_partition_so_pruning_and_deletes_match() {
+ // Guards the reader-side normalization through a real scan: a data
manifest
+ // written when the partition source `x` was `int` must have its
`int(7)`
+ // partition widened to `long(7)` during planning, so (a) a `x = 7`
(long)
+ // filter keeps the file and (b) the equality delete keyed by `long(7)`
+ // attaches. Without the normalization the int/long mismatch drops the
delete
+ // (and prunes the file under the filter).
+ let mut fixture = TableTestFixture::new();
+ fixture.setup_promoted_partition_with_eq_delete().await;
+
+ let tasks: Vec<FileScanTask> = fixture
+ .table
+ .scan()
+ .build()
+ .unwrap()
+ .plan_files()
+ .await
+ .unwrap()
+ .try_collect()
+ .await
+ .unwrap();
+ assert_eq!(tasks.len(), 1);
+ assert_eq!(
+ tasks[0].deletes().len(),
+ 1,
+ "equality delete must attach after widening the old int partition
to long"
+ );
+
+ let tasks: Vec<FileScanTask> = fixture
+ .table
+ .scan()
+ .with_filter(Reference::new("x").equal_to(Datum::long(7)))
Review Comment:
Good call. Added!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
