laskoviymishka commented on PR #3295: URL: https://github.com/apache/iceberg-rust/pull/3295#issuecomment-6312442801
LGTM, thx for the split, it's much easier to follow commit by commit. Two small things inline: capping the effective size at `i32::MAX` so we accept the same range as Java's client, and putting the offending value in the `rest-page-size` error. With those I think it's good to go. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
