yusufyildiz34 commented on PR #18592: URL: https://github.com/apache/iceberg/pull/18592#issuecomment-6313576807
It picks up #17143, which the stale bot closed in August before anyone reviewed it. The bug is the same, but the fix is in a different place: #17143 wrapped the Parquet `Dictionary` in `VectorizedArrowReader` so it returned micros, while this adds a `TIMESTAMP_MILLIS` dictionary accessor in `GenericArrowVectorAccessorFactory`, the same way `DictionaryTimestampInt96Accessor` handles INT96, so `VectorHolder.dictionary()` keeps returning the values stored in the file. I also asked @AbdelrahmanElhawary on #17135; if they'd rather reopen their PR, I'm happy to close this one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
