nastra commented on code in PR #18585: URL: https://github.com/apache/iceberg/pull/18585#discussion_r4339249969
########## format/spec.md: ########## @@ -949,7 +950,6 @@ Each stats struct holds statistics for one table field. It may contain the follo |-------------|--------|---------------------------|---------------------------|-----------------------------------------------|-------------| | _optional_ | 1 | `lower_bound` | Field type or `geo_lower` | all primitives or `variant` | Lower bound stored as the field's type, or `geo_lower` for geo types | | _optional_ | 2 | `upper_bound` | Field type or `geo_upper` | all primitives or `variant` | Upper bound stored as the field's type, or `geo_upper` for geo types | -| _optional_ | 3 | `tight_bounds` | `boolean` | all primitives except for `geometry` and `geography` | When true, `lower_bound` and `upper_bound` must be equal to the min and max values | Review Comment: my thinking is that the Spec is still in development and not finalized, so it seems weird to have offset 3 not being used for anything just because we decided to move things around. I'd rather adjust the offsets now instead of later before voting on the v4 spec and realize that one of the offsets isn't used, wdyt? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
