pvary commented on code in PR #17610:
URL: https://github.com/apache/iceberg/pull/17610#discussion_r4337364382
##########
data/src/test/java/org/apache/iceberg/data/ReadFormatModelTests.java:
##########
@@ -1843,7 +1921,9 @@ void testReadMetadataColumnRowPosition(FileFormat
fileFormat) throws IOException
@ParameterizedTest
@FieldSource("FILE_FORMATS")
void testReadMetadataColumnIsDeleted(FileFormat fileFormat) throws
IOException {
-
+ assumeFalse(
+ supportsBatchReads() && fileFormat == FileFormat.PARQUET,
+ "Reading _deleted without a delete filter is not supported by the
vectorized reader");
Review Comment:
Could we move this code to the Vectorized tests?
Having these checks hides them when we want to understand what is supported
in Vectorized reads, and what is not
##########
data/src/test/java/org/apache/iceberg/data/ReadFormatModelTests.java:
##########
@@ -1863,7 +1943,10 @@ void testReadMetadataColumnIsDeleted(FileFormat
fileFormat) throws IOException {
@ParameterizedTest
@FieldSource("FILE_FORMATS")
void testReadMetadataColumnRowLineage(FileFormat fileFormat) throws
IOException {
-
+ // TODO: remove when https://github.com/apache/iceberg/issues/18543 is
fixed
+ assumeFalse(
Review Comment:
Same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
