kevinjqliu commented on PR #3969: URL: https://github.com/apache/iceberg-python/pull/3969#issuecomment-6327375653
Actually Matt has a good point about leaving these as private functions for now. We can use `_encrypt_ags1`/`_decrypt_ags1` until the manifest reader lands. btw i pushed up a branch with my review iterations, feel free to take a look and take any (or none) of the proposed changes 😄 https://github.com/apache/iceberg-python/compare/main...kevinjqliu:iceberg-python:kevinjqliu-review-pr-3969 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
