dina-kar commented on PR #3232: URL: https://github.com/apache/iceberg-rust/pull/3232#issuecomment-6331420866
@laskoviymishka, would you mind if we finished this PR? It hasn't changed since mid-September, and the deletion-vector writer in #2580 builds on it. If you're fine with that, I'd open a PR that keeps your two commits as they are, with you as their author. On top of them it would add: - the fix for the conflict with #3107; - the rustdoc fix mentioned above; - the `public-api.txt` entry; - a test against Spark-written deletion vectors. I'd also handle the open review point about positions of 2^63 and above. If you'd rather keep going yourself, that's great too. Just say so and I'll help with review and tests instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
