raghavyadav01 commented on PR #18590: URL: https://github.com/apache/iceberg/pull/18590#issuecomment-6346028074
Thanks @zhengxiang378928908-code for spotting this — you're right, and #18414 should be the one that goes forward. It predates this by 13 days, it's from @LuciferYang who reported #18412 in the first place, and it carries the wider coverage: `TestResiduals`, `TestTruncatesResiduals` and `TestDeleteFiles` against the two files here. The production change is byte-identical, so there is nothing here that #18414 lacks. Closing in favour of it. I'll review #18414 instead — apologies for the duplicated review effort, I checked the issue for people claiming it but not for an existing PR referencing it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
