RussellSpitzer commented on code in PR #18301: URL: https://github.com/apache/iceberg/pull/18301#discussion_r4351134993
########## format/spec.md: ########## @@ -1355,7 +1357,14 @@ Notes: ### Delete Formats -This section details how to encode row-level deletes in Iceberg delete files. Row-level deletes are added by v2 and are not supported in v1. Deletion vectors are added in v3 and are not supported in v2 or earlier. Position delete files must not be added to v3 tables, but existing position delete files are valid. Equality delete files must not be added to v4 tables, but existing equality delete files are valid. +This section details how to encode row-level deletes in Iceberg delete files. + +Row-level deletes have changed across Iceberg versions: + +* v4 allows writing only deletion vectors that are co-located with data file metadata Review Comment: I think the bullets here are actually correct as is. The unratified part is actually ratified now and was basically set in stone at the time this PR was written anyway. I would probably switch the order so we can just detail the changes? - v1 does not support row level deletes - v2 allows position delete files and equality delete files stored as entries in delete manifests - v3 forbids new position delete files and allows deletion vectors as a replacement - v4 forbids new equality deletes and delete manifests. Deletion vector metadata is now part of the manifest entries of the data files they modify. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
