lishuxu commented on code in PR #1041:
URL: https://github.com/apache/iceberg-cpp/pull/1041#discussion_r4357040319
##########
src/iceberg/catalog/rest/rest_catalog.cc:
##########
@@ -511,6 +514,30 @@ Result<std::shared_ptr<RestCatalog>> RestCatalog::Make(
ICEBERG_ASSIGN_OR_RAISE(auto client, client_factory(final_config));
ICEBERG_PRECHECK(client != nullptr, "HTTP client factory returned null");
+
+ // Warn if oauth2-server-uri is neither explicitly configured nor protected
from
+ // server overrides while using credential auth.
Review Comment:
Good catch. Java also warns when token is set; updated the condition to
has_credential || has_token to match.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
