koodin9 commented on PR #18003: URL: https://github.com/apache/iceberg/pull/18003#issuecomment-6360637699
Thanks for the review. I rebased on main and pushed one commit per comment; each inline reply names its commit. The last commit, 286bc46e5, drops the comparison budget and the range splitting, so it is mostly deletions in `KeyFilters` and its tests. It partly undoes two earlier commits: the range test added in b0e5bc8cb now runs through the bounds path, and the `splitIntoRanges` tests that 8ec2676a3 moved are removed together with the method. I kept both commits so each comment has its own change, but none of the removed code remains in the final diff. While fixing the empty-branch path, I also found that a branch that does not exist yet was treated as empty, although a commit to it builds on the current snapshot of main. 92ee01a75 handles both cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
