zhengxiang378928908-code commented on PR #18407: URL: https://github.com/apache/iceberg/pull/18407#issuecomment-6367704669
Thanks, the staged-ID check in `40d3be0ef` looks right to me, and the cherry-pick test covers the fast-forward case. Locally on `94bb0d307`, `TestSnapshotProducer`, `TestRowDelta`, `TestFastAppend`, `TestSnapshotManager` and `TestTransaction` have no failures (773 tests, 64 skipped). `build-checks` fails on checkstyle: the `snapshotId` parameters of `cleanupAfterSuccessfulCommit` (line 614) and `cleanAfterFailedCommit` (line 649) hide the `snapshotId` field (`HiddenField`). Renaming them, for example to `committedSnapshotId` and `attemptSnapshotId`, should fix it. The `hive2-tests` failure is a 429 from Maven Central while resolving `uzaygezen-core`, so a rerun should clear it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
