anoopj commented on code in PR #18546:
URL: https://github.com/apache/iceberg/pull/18546#discussion_r4364070588
##########
core/src/main/java/org/apache/iceberg/BaseOverwriteFiles.java:
##########
@@ -108,6 +119,8 @@ public OverwriteFiles validateFromSnapshot(long snapshotId)
{
public OverwriteFiles conflictDetectionFilter(Expression
newConflictDetectionFilter) {
Preconditions.checkArgument(
newConflictDetectionFilter != null, "Conflict detection filter cannot
be null");
+ Preconditions.checkState(
+ !rowFilterSet, "Cannot set a conflict detection filter when
overwriting by row filter");
Review Comment:
Agree. I tried to consolidate because the current engines are using it
mutually exclusively. I do agree that this mutual exclusion is unnecessary, we
can always late bind the filter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
