rich7420 commented on code in PR #3507:
URL: https://github.com/apache/iceberg-rust/pull/3507#discussion_r4366124541
##########
crates/iceberg/src/expr/visitors/page_index_evaluator.rs:
##########
@@ -2312,6 +2341,136 @@ mod tests {
Ok(())
}
+ #[test]
+ fn eval_keeps_int32_pages_of_promoted_long_field() -> Result<()> {
+ // An `int` -> `long` promotion leaves older files with INT32 page
+ // bounds, which can't be compared with a `long` literal.
+ let (metadata, _temp_file) = create_parquet_file_from_values(&[100,
200, 300, 400], |v| {
+ Arc::new(Int32Array::from(v))
+ })?;
+
+ assert_keeps_all_pages(&metadata, PrimitiveType::Long, 4096, [
+ Reference::new("col").less_than(Datum::long(250)),
Review Comment:
Good idea, thanks! Added both in 13f1acad for the `long` field over `INT32`
pages. Each one fails without the fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
