dannycjones opened a new issue, #3524: URL: https://github.com/apache/iceberg-rust/issues/3524
I'm proposing to adopt Rust type aliases for schema IDs, field IDs, etc.. Bits of this already exist for schema IDs. I propose completing that, and adopting this across other ID types. Firstly, this improves readability as things like hash maps will immediately convey what it is mapping. For example: `HashMap<SchemaId, Schema>`, `HashMap<FieldId, ArrowFieldIdx>`. Secondly, should we wish to migrate to Rust's newtype idiom then this is already covering half the battle. We'd only need to update construction and unwrapping points. I'll start with Schema ID and slowly migrate bits across. Please share if you have any concerns here. Note, I am _not_ recommending migrating to newtypes at this time, that is a separate discussion which requires much more nuance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
