vbhanuchander-lang commented on PR #17644: URL: https://github.com/apache/iceberg/pull/17644#issuecomment-6386174763
Yes, still on it, sorry for the delay. Pushed an update: - Precondition moved into `asMapType`, renamed to `FlinkMapTypeUtil` / `isMapType`, and the unresolvable link is now `code`. - Added `TestFlinkMultisetType`, an end-to-end SQL test that inserts a `COLLECT()` multiset and reads the counts back for Parquet, Avro and ORC. It uses a `'connector'='iceberg'` table, because inside the Iceberg catalog Flink sees the column as a MAP and the multiset never reaches the writer. It fails on main with the original errors. - Went through AGENTS.md: dropped the test that only checked the existing `FlinkSchemaUtil` conversion, and trimmed the Javadoc/comments. @c-kaustubh thanks for the offer. The DynamicSink side (`DataConverter#get` has no MULTISET case) is still open as a follow-up if you want to take it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
