kevinjqliu commented on code in PR #4082:
URL: https://github.com/apache/iceberg-python/pull/4082#discussion_r4368537136
##########
tests/io/test_pyarrow.py:
##########
@@ -1321,11 +1321,10 @@ def test_projection_concat_files(schema_int: Schema,
file_int: str) -> None:
assert repr(result_table.schema) == "id: int32"
-def test_identity_transform_column_projection(tmp_path: str, catalog:
InMemoryCatalog) -> None:
[email protected]("with_field_ids", [False, True], ids=["name-mapping",
"field-ids"])
+def test_identity_transform_column_projection(tmp_path: str, catalog:
InMemoryCatalog, with_field_ids: bool) -> None:
# Test by adding a non-partitioned data file to a partitioned table,
verifying partition value
# projection from manifest metadata.
- # TODO: Update to use a data file created by writing data to an
unpartitioned table once add_files supports field IDs.
- # (context:
https://github.com/apache/iceberg-python/pull/1443#discussion_r1901374875)
Review Comment:
this comment is outdated and can be removed, 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
