kevinjqliu commented on code in PR #4110:
URL: https://github.com/apache/iceberg-python/pull/4110#discussion_r4368580069
##########
pyiceberg/table/update/spec.py:
##########
@@ -268,7 +268,7 @@ def _add_new_field(
return PartitionSpec(*partition_fields, spec_id=new_spec_id)
def _partition_field(self, transform_key: tuple[int, Transform[Any, Any]],
name: str | None) -> PartitionField:
- if self._transaction.table_metadata.format_version == 2:
+ if self._transaction.table_metadata.format_version >= 2:
Review Comment:
looks like we need to follow up and fix a number of these in the code base
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
