kevinjqliu opened a new pull request, #4150:
URL: https://github.com/apache/iceberg-python/pull/4150
<!--
Thanks for opening a pull request!
-->
<!-- In the case this PR will resolve an issue, please replace
${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
<!-- Closes #${GITHUB_ISSUE_ID} -->
# Rationale for this change
Adds an `AGENTS.md` testing guideline to prefer a `for` loop in a single
test over `@pytest.mark.parametrize`. Each parametrized case is a separate
pytest item with its own collection, setup, and reporting overhead, which adds
up across the suite.
Measured locally with the project's `tests/conftest.py` (`pytest -m unit
-q`, trivial bucket-transform assertion as the test body):
| Cases | `parametrize` | `for` loop |
|---|---|---|
| 1,000 | ~0.30s | ~0.01s |
| 10,000 | ~2.95s | ~0.01s |
Roughly 0.3ms of overhead per case. About 2,258 of the 4,022 collected unit
tests (56%) are parametrized cases.
## Are these changes tested?
Documentation-only change. `prek` hooks (markdownlint, codespell,
end-of-file, trailing whitespace) passed on commit.
## Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
