efegokdemir opened a new pull request, #18652: URL: https://github.com/apache/iceberg/pull/18652
Fixes #18646. `TableMetadata.Builder.addSnapshot` now rejects v3-only key and row-lineage fields before v3, requires `manifest-list` in v2/v3 and `summary` from v2 onward, and validates them before mutating the builder. The manifest-list check is limited to v2/v3 because v4 uses a root manifest. Upgrading legacy metadata to v3 advances `next-row-id` past existing snapshot row ranges. Verified: `./gradlew :iceberg-core:test --tests org.apache.iceberg.TestTableMetadata` (93 tests), `./gradlew :iceberg-core:build -x test -x integrationTest`, Checkstyle and Spotless. Regressions failed on pristine main: 11 snapshot-field cases failed; the upgrade case left `next-row-id` at 0 instead of 5. --- **AI Disclosure** - Model: GPT-6 - Platform/Tool: Codex - Human Oversight: fully reviewed - Prompt Summary: Generate `TableMetadata.Builder` version checks, legacy row-ID upgrade handling, and regression tests for #18646. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
