stevenzwu commented on code in PR #18604:
URL: https://github.com/apache/iceberg/pull/18604#discussion_r4374213379


##########
core/src/main/java/org/apache/iceberg/StatsUtil.java:
##########
@@ -325,4 +336,181 @@ private static boolean isScalar(Schema schema, 
Map<Integer, Integer> parentIndex
 
     return true;
   }
+
+  /** Inclusive source column bounds for a partition value. Upper is null when 
unbounded. */
+  record PartitionSourceBounds(Object lower, Object upper) {}
+
+  /**
+   * Returns the source column bounds for a partition value, or null for a NaN 
identity value.
+   *
+   * @throws IllegalArgumentException if the transform does not preserve order 
or the value is null
+   */
+  static PartitionSourceBounds sourceBoundsFor(

Review Comment:
   `PartitionSourceBounds` name seems a bit inaccurate. It is not the 
lower/upper bound for the partition source column. Rather, it is for the 
lower/upper bound of the partition transform output.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to