jopdorp commented on code in PR #3432:
URL: https://github.com/apache/iceberg-rust/pull/3432#discussion_r4377404547
##########
crates/iceberg/src/spec/values/datum.rs:
##########
@@ -330,6 +334,8 @@ impl Display for Datum {
) => {
write!(f, "{}", decimal_from_i128_with_scale(*val, *scale))
}
+ // The scale lives on the dropped source type, so only the
unscaled value is left.
+ (PrimitiveType::Unknown, PrimitiveLiteral::Int128(val)) =>
write!(f, "{val}"),
Review Comment:
Took the first option: the commit path now formats deleted files with the
newest schema that still has their partition sources, so a dropped decimal
source prints `p=1.23` like Java and Go, in 14012927f. The unscaled arm stays
only so a direct `partition_to_path` call with a schema missing the source does
not panic, happy to drop it if you would rather.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
