ninglinLiu commented on PR #3528: URL: https://github.com/apache/iceberg-rust/pull/3528#issuecomment-6418856855
Thanks @dannycjones, addressed in de189c9: - Applied the `cargo package` suggestion: dropped `--no-verify` (implied by `--list`) and moved the `--allow-dirty` comment inline. - `require_cargo` now uses the same `subprocess.run([..."--version"])` pattern as `require_cargo_deny`, and the two helpers sit next to each other (no more `shutil`). - `cargo metadata` no longer captures stderr, so warnings show up as they did in the shell script. - Replaced the bare `samefile` with an `is_same_file` helper that returns `False` when either path is missing. With the root `NOTICE` removed the script now reports `Repository root NOTICE does not resolve to a non-empty file` (plus one line per crate) instead of raising. - Applied the help-text suggestion for `crates`. `python3 dev/release/licenses.py crates check` still passes for all publishable crates on this branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
