zeroshade opened a new pull request, #154: URL: https://github.com/apache/terraform-provider-iceberg/pull/154
`github.com/RoaringBitmap/roaring/v2` is linked into the provider binary (via `iceberg-go/table/dv`). Its `LICENSE` is the Apache-2.0 text with the Go project's BSD-3-Clause license appended, covering the parts of `runcontainer.go` derived from the Go standard library. go-licenses v1.6.0 classifies that file as Apache-2.0 only, so `dev/update_licenses.sh` dropped the module from the binary inventory, and the BSD-3-Clause grant was not reproduced in the convenience binaries. It was found while reviewing the license files for 0.2.0-rc1. This pins the classification in `dev/licenses/overrides.tsv`, as is already done for `github.com/klauspost/compress`, which ships the same kind of combined license file. It then regenerates the inventory: - `LICENSE-binary`: lists `github.com/RoaringBitmap/roaring/v2` under BSD 3-Clause - `licenses-binary/LICENSE-RoaringBitmap-roaring.txt`: the module's full LICENSE (Apache-2.0 and BSD-3-Clause texts) `dev/update_licenses.sh --check` reports `LICENSE-binary and licenses-binary/ match the linked dependencies.` Two other embedded notices found in the same review are not part of this PR. Both are single-file headers with no license file, so the override mechanism can't express them: - `hashicorp/terraform-plugin-go/tftypes/walk.go`: MIT, © Martin Atkins (from go-cty) - `hashicorp/go-hclog/stacktrace.go`: MIT, © Uber Technologies -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
