Copilot commented on code in PR #3520:
URL: https://github.com/apache/iceberg-rust/pull/3520#discussion_r4380664417
##########
.github/actions/setup-builder/action.yml:
##########
@@ -42,6 +42,8 @@ runs:
echo "Installing toolchain according to rust-toolchain.toml"
rustup show
rustup component add rustfmt clippy
+ # Unused, and its version varies by runner image, which splits
rust-cache keys.
+ rustup toolchain uninstall stable
Review Comment:
`rustup toolchain uninstall stable` can make the job less reliable if
`stable` is the current default toolchain (common on GitHub runners) or if a
particular `rustup` version returns a non-zero exit code when `stable` isn't
installed. To keep CI robust while still achieving the cache-key goal, consider
(mandatory): (1) ensuring a non-stable toolchain is set as default first (e.g.,
the currently-active toolchain from the repo’s `rust-toolchain.toml`), and (2)
making the uninstall idempotent by guarding it (check `rustup toolchain list`
first) or tolerating 'not installed' errors explicitly. This prevents
accidental breakage of later steps that run outside the repo directory (where
`rust-toolchain.toml` overrides may not apply).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
