sezruby commented on code in PR #18603:
URL: https://github.com/apache/iceberg/pull/18603#discussion_r4381293948
##########
core/src/test/java/org/apache/iceberg/TestRowDelta.java:
##########
@@ -1324,6 +1324,163 @@ public void testConcurrentConflictingRowDelta() {
.hasMessageStartingWith("Found new conflicting delete files");
}
+ private RowDelta updateOfFileA(long startingSnapshotId, DeleteFile
fileADeletes) {
+ return table
+ .newRowDelta()
+ .toBranch(branch)
+ .addRows(FILE_B)
+ .addDeletes(fileADeletes)
+ .validateFromSnapshot(startingSnapshotId)
+ .conflictDetectionFilter(Expressions.alwaysTrue())
+ .validateDataFilesExist(ImmutableList.of(FILE_A.location()))
Review Comment:
Changed the modified set instead of the helper: the files passed to
validateDataFilesExist are no longer included, so it is now the commit's delete
targets and removed files, as the Javadoc already says. Spark passes the same
delete targets to validateDataFilesExist, so this only removed a duplicate. The
tests now depend on the targets: leaving them out of the set fails
concurrentDeleteForModifiedDataFileConflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
