kevinjqliu commented on code in PR #18660:
URL: https://github.com/apache/iceberg/pull/18660#discussion_r4382843593
##########
runtime-deps.gradle:
##########
@@ -46,16 +47,24 @@
// 2. ./gradlew generateRuntimeDeps -DallModules --
auto-updates all baselines
// 3. Update LICENSE and NOTICE if dependency licenses changed -- This is a
Manual Step
// 4. Commit
+//
+// Options, set via ext before applying:
+// runtimeDepsFile - baseline path relative to the project
directory
+// (default: runtime-deps.txt)
+// runtimeDepsConfiguration - configuration to resolve (default:
runtimeClasspath)
+//
+// Apply once per baseline; each apply adds that baseline to the same two
tasks.
-def depsFile = file("${projectDir}/runtime-deps.txt")
+def depsFile = file("${projectDir}/${project.findProperty('runtimeDepsFile')
?: 'runtime-deps.txt'}")
+def depsConfiguration = project.findProperty('runtimeDepsConfiguration') ?:
configurations.runtimeClasspath
Review Comment:
made these configurable, default is still the same
##########
kafka-connect/build.gradle:
##########
@@ -253,6 +253,11 @@
project(':iceberg-kafka-connect:iceberg-kafka-connect-runtime') {
it.file in [hiveDistZip.archiveFile.get().asFile,
hiveDistTar.archiveFile.get().asFile]
}
+ // track main and hive distributions separately; set properties before each
apply
+ ext.runtimeDepsFile = 'main/runtime-deps.txt'
+ apply from: "${rootDir}/runtime-deps.gradle"
+ ext.runtimeDepsFile = 'hive/runtime-deps.txt'
+ ext.runtimeDepsConfiguration = configurations.hive
apply from: "${rootDir}/runtime-deps.gradle"
Review Comment:
run twice, for `main` and `hive`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
