Prathameshk2696 commented on code in PR #18624:
URL: https://github.com/apache/iceberg/pull/18624#discussion_r4385343211
##########
core/src/test/java/org/apache/iceberg/TestRemoveSnapshots.java:
##########
@@ -1970,6 +2024,22 @@ private RemoveSnapshots removeSnapshots(Table table) {
return (RemoveSnapshots)
removeSnapshots.withIncrementalCleanup(incrementalCleanup);
}
+ // simulates a snapshot with no summary, which is valid for snapshots
written before summaries
+ // were introduced
+ private void dropSnapshotSummary(long snapshotId) throws IOException {
Review Comment:
Renamed the method to `addSnapshotWithoutSummary`.
@stevenzwu Should we remove test addition for null check if test addition is
overkill? It did impact the cleanup behavior as IncrementalFileCleanup logic
encountered NPE and failed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
