ninglinLiu opened a new pull request, #3553: URL: https://github.com/apache/iceberg-rust/pull/3553
## Which issue does this PR close? - Follow-up to #3528, as suggested by @kevinjqliu in https://github.com/apache/iceberg-rust/pull/3528 (run `licenses.py crates check` in `verify_rc.sh` behind a `--check_crate_licenses` toggle). ## What changes are included in this PR? RC voters currently only get the "every publishable crate packages the root `LICENSE` and `NOTICE`" guarantee from CI. This adds it to `dev/release/verify_rc.sh`, run against the extracted source archive: - New `--check_crate_licenses <0|1>` option (also accepts `--check-crate-licenses`), default `1`, validated like the other boolean options. - `check_crate_licenses` requires `cargo` and `python3` and runs `python3 <archive>/dev/release/licenses.py crates check`. `licenses.py` resolves `REPO_ROOT` from its own path, so it checks the extracted archive rather than the local checkout. - Usage text and `dev/release/README.md` document the option and default; the "skip everything" example passes `--check_crate_licenses 0`. ## Are these changes tested? Ran `bash -n dev/release/verify_rc.sh`, checked `--help` output and that invalid values (e.g. `--check_crate_licenses 2`) are rejected, and ran the script with `--download 0` against a locally built source archive with the check enabled and disabled. This PR was prepared with AI assistance and reviewed/tested by the author. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
