zhjwpku commented on code in PR #1064:
URL: https://github.com/apache/iceberg-cpp/pull/1064#discussion_r4384871650
##########
src/iceberg/test/CMakeLists.txt:
##########
@@ -21,6 +21,11 @@ set(ICEBERG_TEST_RESOURCES
"${CMAKE_SOURCE_DIR}/src/iceberg/test/resources")
configure_file("test_config.h.in" "test_config.h")
+if(WIN32 AND CMAKE_GENERATOR MATCHES "Ninja")
Review Comment:
nit: A short comment would be worth it here.
```suggestion
# vcpkg's z-applocal POST_BUILD copies dependency DLLs into this shared test
# directory. Ninja appends that command to the link recipe, so a link pool of
# depth 1 also serializes the copies. Parallel copies fail with a file lock
# (https://github.com/apache/iceberg-cpp/issues/944).
if(WIN32 AND CMAKE_GENERATOR MATCHES "Ninja")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
