zeroshade commented on PR #2334: URL: https://github.com/apache/iceberg-go/pull/2334#issuecomment-6446553022
@badalprasadsingh thanks, added notes for all six in `017f9e4`, checked against the code on main: - #2067: `io.IO.Open`/`Remove` take a `context.Context`, and `maintenance.WithCleanupDeleteFunc` takes `func(context.Context, string) error`. - #2290: `hadoop.NewCatalog(ctx, name, warehouse, props)`. - #2294: `config.LoadConfig` returns `([]byte, error)`; `LoadConfigFile` is removed. - #2307: `NewSchemaFromJsonFields` → `NewSchemaFromJSONFields`. - #2310: the `glue`, `sigv4` and `utils` AWS identifiers and `config.CatalogConfig.AWSProfile` (the `aws-profile` YAML key is unchanged). - #2313: `NewTransactionOnBranch` returns `(*Transaction, error)`, and `NewTransactionOnBranchWithError` is removed. @laskoviymishka on parking: I'd rather land this now so `main` isn't missing notes for already-merged breaking changes. I'll keep resolving the `releases.md` conflicts as the remaining PRs land, and any that land without a note can be added here or in a follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
