kevinjqliu commented on code in PR #3558: URL: https://github.com/apache/iceberg-rust/pull/3558#discussion_r4392325776
########## .cargo/audit.toml: ########## @@ -64,4 +64,21 @@ ignore = [ # once the transitive dependency set permits quick-xml >=0.41.0. "RUSTSEC-2026-0194", "RUSTSEC-2026-0195", + # `zstd` < 0.14.3 / `zstd-safe` < 8.2.0 memory-safety bugs. + # + # Fixed only in zstd 0.14, but parquet 58 and apache-avro 0.21 require + # zstd 0.13. Remove once on parquet >= 60 + # (https://github.com/apache/iceberg-rust/pull/3257), an apache-avro release + # after 0.21, and workspace `zstd` >= 0.14.3. + # + # None of the affected code is reachable here. To re-check, run + # `cargo tree --workspace --all-features --target all -e features -i zstd-safe` + # and confirm only `std` is enabled. + # + # Affects only zstd's `with_context` constructors, which nothing calls. + "RUSTSEC-2026-0391", + # Requires the `seekable` feature, which is off. + "RUSTSEC-2026-0398", + # Requires the `legacy` feature, which is off. + "RUSTSEC-2026-0403", Review Comment: #3538 ########## bindings/python/about.toml: ########## @@ -67,23 +67,6 @@ license = "MIT" checksum = "3823dda7cf046602f4b4e77ec8e227863dc4736037cc85bb33d9f19febe16bb7" path = "LICENSE.txt" -# zstd-sys vendors zstd's C code (BSD-3-Clause, Meta) next to the Rust Review Comment: why this change? I see the corresponding PR is not merged https://github.com/apache/iceberg-rust/pull/3542/changes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
