shangxinli commented on code in PR #1054:
URL: https://github.com/apache/iceberg-cpp/pull/1054#discussion_r4392623674
##########
src/iceberg/manifest/manifest_reader.cc:
##########
@@ -318,6 +323,7 @@ Result<std::vector<ManifestFile>>
ParseManifestList(ArrowSchema* arrow_schema,
ICEBERG_RETURN_UNEXPECTED(AssertViewTypeAndChildren(
&view, ArrowType::NANOARROW_TYPE_STRUCT, schema.fields().size(),
"manifest_list"));
+ ICEBERG_RETURN_UNEXPECTED(AssertChildrenLength(&view, "manifest_list"));
Review Comment:
Fair, nanoarrow's default validation already checks struct child length
against the parent for every STRUCT node recursively, so this isn't a gap.
Dropping it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
