kevinjqliu opened a new pull request, #3562: URL: https://github.com/apache/iceberg-rust/pull/3562
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> - N/A Related: #3561 (independent, merges cleanly in either order). ## What changes are included in this PR? <!-- Provide a summary of the modifications in this PR. List the main changes such as new features, bug fixes, refactoring, or any other updates. --> `cargo about generate --fail` exits 0 when a clarification's checksum no longer matches. It only logs a `WARN` and falls back to the license template, so the wheel LICENSE gets `<year>`-style placeholders instead of the crate's text, and CI still passes. Only the manual pre-release check caught this. - The `generate-python-license` action now fails on a `WARN` or a placeholder, so a dependency bump that needs an `about.toml` update fails in its own PR. `LICENSING.md` drops the clarifications from the manual pre-release list. - Drop the zstd-sys clarification. With cargo-about 0.9.2 (what CI uses) the generated LICENSE is byte-identical without it, and its checksums go stale on every zstd-sys bump (they needed updating in #3542). - PR CI runs the action on Linux only. On the latest main run it took 70s on Windows, 44s on Ubuntu and 39s on macOS, and the output doesn't depend on the OS. Release and nightly still run it for every wheel. ## Are these changes tested? <!-- Specify what test covers (unit test, integration test, etc.). If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> Manually, with cargo-about 0.9.2: - Ran the action's generate step against the current config: passes. Also against a stale libm checksum (fails on the `WARN`), the alloc-stdlib clarification removed (fails on the placeholder), and a cargo-about error (fails). - Generated with and without the zstd-sys clarification: byte-identical. - On this branch, from `bindings/python`: `cargo about generate -c about.toml --locked --fail --manifest-path Cargo.toml about.hbs` exits 0, no `WARN` on stderr, no `<year>|<owner>|<copyright holders>` in stdout. - Both changed YAML files parse. ## AI Disclosure <!-- https://iceberg.apache.org/contribute/#guidelines-for-ai-assisted-contributions --> Written with GitHub Copilot. Reviewer focus: matching plain `WARN` (cargo-about colours `[WARN]` even when piped, so the bracketed form doesn't match), and whether failing release/nightly on a `WARN` is the desired trade-off. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
