mxm commented on code in PR #18602:
URL: https://github.com/apache/iceberg/pull/18602#discussion_r4399451818
##########
flink/v2.3/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/HashKeyGenerator.java:
##########
@@ -344,7 +346,7 @@ static class SelectorKey {
this.branch = branch;
this.schemaId = tableSchemaId;
this.specId = tableSpecId;
- this.schema = tableSchemaId == null ? schema : null;
+ this.schema = tableSchemaId == null ? schema.asStruct() : null;
Review Comment:
The schema id is used when we already have a corresponding table schema
(immediate update). The line above is for the non-immediate path where we do
not have a table schema yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
