ump45nose commented on code in PR #3522:
URL: https://github.com/apache/iceberg-rust/pull/3522#discussion_r4401225824
##########
crates/iceberg/src/spec/values/primitive.rs:
##########
@@ -159,3 +176,23 @@ impl PrimitiveLiteral {
}
}
}
+
+const MICROSECONDS_PER_DAY: i64 = 86_400_000_000;
+const NANOSECONDS_PER_DAY: i64 = 86_400_000_000_000;
+
+/// Converts `days` from the epoch to a timestamp literal in units of
`units_per_day`.
+fn date_to_timestamp(
Review Comment:
Good catch — handled. `Datum::try_from_bytes` now takes the 4-byte path for
`Timestamp` / `TimestampNs` the same way `Long` does and reuses
`date_to_timestamp`. Added
`test_parse_manifest_promotes_date_bounds_under_timestamp_schema` next to
`test_parse_manifest_promotes_writer_types`, plus
`avro_bytes_timestamp_from_date` for the byte-level round-trip.
(AI-assisted reply.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
