fanruan-tuco commented on code in PR #18522:
URL: https://github.com/apache/iceberg/pull/18522#discussion_r4402511873
##########
core/src/main/java/org/apache/iceberg/util/ParallelIterable.java:
##########
@@ -286,7 +313,9 @@ public Optional<Task<T>> get() {
break;
}
+ // Add to the queue before waking the consumer, or it may wait again
and get stuck.
Review Comment:
The order matters, so I added this comment to explain why.
`TestParallelIterable#wakesOnDataBeforeTaskCompletes` covers the wake-up
behavior. Reversing these two lines could cause the test to fail, but it isn't
guaranteed to catch that race.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
