zeroshade opened a new pull request, #2346: URL: https://github.com/apache/iceberg-go/pull/2346
`main` does not compile the `table` test package since e904fb4 (#2100), so every open PR's build/test/integration checks fail (e.g. #2334). #2336 (`refactor(io)!: make writes and walks context-aware`) changed `WriteFile` to take a `context.Context`, and `processManifests` now takes one too. Tests that landed alongside still used the old signatures: - `table/commit_retry_test.go:1471,1479` — `WriteFile(path, data)` - `table/rewrite_manifests_internal_test.go:412,420,426` — `WriteFile(path, data)`, `processManifests(manifests)` Each PR was green on its own; the combination was never built. This passes `t.Context()` (or the callback's `ctx`) at those five call sites. No non-test changes. Verified: `go vet ./...` clean; `go test ./... -count=1` passes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
