zeroshade opened a new pull request, #2348: URL: https://github.com/apache/iceberg-go/pull/2348
Resolves the `Schema.FindFieldByIDRef` / `FieldsRef` item in #2062 (decision: keep the sentinel). `Schema.FieldsRef`, `Schema.FindFieldByIDRef` and `PartitionSpec.FieldsRef` take an `internal.SchemaRef` / `internal.PartitionSpecRef` argument, which code outside this module cannot construct, so only iceberg-go's own packages can call them. They exist so hot paths can read schema- and spec-owned fields without the clone that `Fields()` / `FindFieldByID()` make (#1534, #1945, #1957). Hiding them entirely would mean either `go:linkname` (removed in #2066) or function variables set from an `init()` to break the `iceberg` ↔ `internal` import cycle, adding an indirect call on those hot paths. Instead, this documents that they are module-internal and not covered by compatibility guarantees, and points external users at the cloning accessors. Doc comments only; no code changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
