hcrosse commented on issue #2339: URL: https://github.com/apache/iceberg-go/issues/2339#issuecomment-6479391372
Thanks @tanmayrauth and @zeroshade for reviewing the proposal. I agree on the `PostCommit` fix, and yes, the rebuild hook will regenerate expiration's `AssertRefSnapshotID` requirements for each attempt. I'll also have `PostCommit` skip the manifest list of any snapshot still in `postTable`, as Java's [`ReachableFileCleanup`](https://github.com/apache/iceberg/blob/6275107e38cc87a7d416ef231019ceb51556f196/core/src/main/java/org/apache/iceberg/ReachableFileCleanup.java#L62-L73) does. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
