fivetran-rahulprakash commented on PR #18420: URL: https://github.com/apache/iceberg/pull/18420#issuecomment-6488032469
> The request-initializer copy is correct for anyone who constructs `BigQueryMetastoreClientImpl` with `BigQueryOptions` (`>= 0` applied, `0` = no timeout, auth and 409 conversion kept). Through the shipped catalog it is not configurable: `BigQueryMetastoreCatalog.initialize` uses `metastoreOptions()`, which never calls `setTransportOptions`, and the client-injecting `initialize(...)` is package-private. Catalog users only see the read timeout move from `HttpRequest`'s 20 s to the SDK's 60 s (`BigQueryOptions.getDefaultHttpTransportOptions()`); connect stays 20 s; there is no way back. A hung `list(..., listAllTables=false)` load now waits 3× as long; a timed-out commit still goes through `checkCommitStatus`. > > I'd retitle this as aligning with the SDK default read timeout and call out 20 s → 60 s in the body. Catalog properties (`gcp.bigquery.http.connect-timeout-ms` / `read-timeout-ms`) can be a follow-up. > > Nits if you're already in the test file: take 60 s from `getDefaultHttpTransportOptions().getReadTimeout()` and 20 s from a plain `HttpRequest` instead of hardcoding; drop `noCrossClientTimeoutLeakage` (nothing is static); `CapturingTransport` keeps the last request, not the first; the "the fix must" comments describe the PR. Thanks for the review, @uros-b. I’ve updated the PR title and description to clarify that the default read timeout changes from 20s to 60s, while the connect timeout remains at 20s. Making these timeout properties configurable through catalog properties is still a follow-up and is not part of this PR. I’ve also addressed the test nits. 🙂 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
