colinmarc opened a new pull request, #3574:
URL: https://github.com/apache/iceberg-rust/pull/3574

   This adds support for converting date values, which helps with predicate 
expressions such as `date > DATE_TRUNC('day', ts)`.
   
   For example, without this, the following datafusion query fails at runtime:
   
   ```sql
   SELECT id FROM p WHERE d < TIMESTAMP '2023-01-05 12:00:00'
   -- IcebergError(DataInvalid): Can't convert datum from timestamp_ns type to 
date type
   ```
   
   ## Which issue does this PR close?
   
   This was originally part of #1569.
   
   ## Are these changes tested?
   
   Yes! I also restructured the datum convert tests, as requested by feedback 
in #1569.
   
   ## AI Disclosure
   
   I wrote this code myself a while ago, but used a model to rebase it.
   
   ## NB
   
   This is the only change requiring us to stay on a fork, so I'd really like 
to get it in.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to