pvary commented on pull request #2119: URL: https://github.com/apache/iceberg/pull/2119#issuecomment-767712301
> > Could we add some tests for this code path? Maybe using some MockClients to check it the reconnect is attempted when needed? > > I agree that it would be great to test this code path, but adding the mock probably isn't that straightforward. Do we have existing mock tests for this that could be adapted? If not, we may want to get it in and then follow up with tests later. Extending the HiveCatalog and overriding the `newClient` method to return a mockClient which throws specific exceptions on specific methods seems like a reasonable effort for preserving the functionality against unintended changes. Would this become more complicated or more brittle than it seems for the first glance @Jecarm? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
