mixermt commented on code in PR #3569:
URL: https://github.com/apache/iceberg-rust/pull/3569#discussion_r4410303935
##########
crates/storage/opendal/src/s3.rs:
##########
@@ -203,4 +206,53 @@ mod tests {
assert!(parse_with(Some("false")));
assert!(!parse_with(Some("true")));
}
+
+ #[derive(Debug)]
+ struct EmptyCredentialLoader;
Review Comment:
nit: this helper sits between `s3_config_parse_path_style_access` and
`test_relativize_path_s3`, but only
`test_s3_factory_custom_credential_loader_serialization_fails` uses it. Could
it move up next to `parse_with` so the helpers are together at the top of the
module?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
